ricardofbarros / linter-js-standard

Atom linter plugin for JavaScript, using JavaScript Standard Style
https://atom.io/packages/linter-js-standard
MIT License
99 stars 48 forks source link

Standard:global package.json support #25

Closed joshmanders closed 9 years ago

joshmanders commented 9 years ago

This supports ignore which is great, if I want to ignore a whole file, but I don't want to ignore files, I want it to not error out on me when I am writing tests. So support for global would be great. :)

{
  "standard": {
    "global": [ "myVar1", "myVar2" ]
  }
}

Ref: https://github.com/feross/standard#i-use-a-library-that-pollutes-the-global-namespace-how-do-i-prevent-variable-is-not-defined-errors

ricardofbarros commented 9 years ago

I will look on this, thank you @killswitch

joshmanders commented 9 years ago

Other than this request, I just started using this plugin and I love it. Thanks for the hard work @ricardofbarros!

uiur commented 9 years ago

+1

LeiZeng commented 9 years ago

+1

dmonad commented 9 years ago

+1

whatyoubendoing commented 9 years ago

:+1:

ricardofbarros commented 9 years ago

This is a very wanted feature, I'm on it. :+1:

ricardofbarros commented 9 years ago

It seems this isn't yet supported in standard CLI,

btw thanks @LeiZeng by opening the issue on standard.

joshmanders commented 9 years ago

Thank you @ricardofbarros !

feross commented 9 years ago

The standard CLI supports --global now, as of 5.0.0-3. This is a prerelease version, so beware if you choose to depend on it that breaking changes may be added before 5.0.0 is released.

ricardofbarros commented 9 years ago

@feross is the 5.0.0 release around the corner? If so I prefer to wait, if not I will implement it now and wait for the release to fix possible breaking changes.

ricardofbarros commented 9 years ago

And thank you @feross for your awesome work :+1:

feross commented 9 years ago

We're waiting for eslint 1.0.0 before releasing standard 5.0.0. eslint released 1.0.0-rc1 last week, so it hopefully won't be too much longer.

I don't expect any breaking changes in the CLI. I meant that we might add/remove rules from the list of new rules in 5.0.0. :+1:

joshmanders commented 9 years ago

Awesome, can't wait to see this.

ricardofbarros commented 9 years ago

As of @2.1.0 this feature is supported. :+1:

Thanks everyone.

joshmanders commented 9 years ago

Awesome work @ricardofbarros