search

ricardofbarros / linter-js-standard

Atom linter plugin for JavaScript, using JavaScript Standard Style
https://atom.io/packages/linter-js-standard
MIT License
99 stars 48 forks source link

does not lint #3

Closed despairblue closed 9 years ago

despairblue commented 9 years ago

Answering the questions from #1

  1. no error in the console while linting (tried saving the file and also starting it from the command palette, all other linters work)
  2. which node: /usr/local/bin/node
  3. process.env.PATH: /home/despairblue/.rvm/bin:/home/despairblue/bin:/home/despairblue/.cabal/bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/opt/android-ndk64:/opt/android-sdk/platform-tools:/opt/android-sdk/tools:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/home/despairblue/.linuxbrew/bin:/home/despairblue/node_modules/.bin:/opt/java6/bin:/home/despairblue/.gem/ruby/2.1.0/bin:/home/despairblue/go/bin

Also I have linter-js-standard installed for a while now, couple of weeks at least, it actually never worked, not even with linter 0.11.0. I just haven't had the time to report it before now.

Command History

     -0:08.6 selection:changed (atom-text-editor.editor.block-cursor-i-beam.is-focused)
     -0:06.0 fuzzy-finder:toggle-file-finder (atom-text-editor.editor.block-cursor-i-beam.is-focused)
     -0:03.4 editor:delete-to-beginning-of-word (atom-text-editor.editor.mini)
     -0:03.1 editor:consolidate-selections (atom-text-editor.editor.mini)
     -0:03.1 core:cancel (atom-text-editor.editor.mini)
     -0:02.7 fuzzy-finder:toggle-file-finder (atom-text-editor.editor.block-cursor-i-beam.is-focused)
     -0:02.1 editor:consolidate-selections (atom-text-editor.editor.mini)
     -0:02.1 core:cancel (atom-text-editor.editor.mini)
     -0:01.7 command-palette:toggle (atom-text-editor.editor.block-cursor-i-beam.is-focused)
     -0:00.0 core:confirm (atom-text-editor.editor.mini)
     -0:00.0 bug-report:open (atom-text-editor.editor.block-cursor-i-beam.is-focused)

Versions

This report was created in and posted from the Atom editor using the package bug-report v0.6.3.

ricardofbarros commented 9 years ago

Will look into this as soon as I got time, so it should be between today and tomorrow.

despairblue commented 9 years ago

:sparkles: thx :smiley:

ricardofbarros commented 9 years ago

Can you tell me which other linters you have enabled? Do you have js hint ?

despairblue commented 9 years ago

Yes, I can try to disable it tomorrow.

On Wed, Apr 8, 2015, 22:57 Ricardo Barros notifications@github.com wrote:

Can you tell me which other linters you have enabled? Do you have js hint ?

— Reply to this email directly or view it on GitHub https://github.com/ricardofbarros/linter-js-standard/issues/3#issuecomment-91035312 .

despairblue commented 9 years ago

I disabled linter-jshint and it still does nothing.

My other linters are: enabled:

disabled:

ricardofbarros commented 9 years ago

Hmm this is very strange, I'll try to duplicate this issue on ubuntu

fannarsh commented 9 years ago

I'm experiencing the same thing, I'm using the default Js Standard Executable Path but I have also the Js Standard npm package install globally. And I installed linter-jshint after I installed linter-js-standard, to see if linter worked at all and at the time I installed linter-js-standard and linter I had jshint installed, v1.3.3 if I remember correctly.

Packages Installed

Versions

fannarsh commented 9 years ago

I have now updated to Atom: 0.192.0 no change

fannarsh commented 9 years ago

I downgraded linter-js-standard to 0.1.1 but that didn't change anything.

ricardofbarros commented 9 years ago

I finally had time to look at this and could fix this.

What was happening is that linter-js-standard linter was configured to received the error stream from stderr. I guess, with the major release v3, feross changed from stderr to stdout, so I just configured linter-js-standard to catch the error stream from stdout, and voila it worked.

Give it a try the last release and give me some feedback, thank you :smile:

fannarsh commented 9 years ago

:+1: 0.1.5 works for me

ricardofbarros commented 9 years ago

Great :smiley:, now let's wait for @despairblue feedback

despairblue commented 9 years ago

@ricardofbarros it works :clap: thanks :smiley:

zeke commented 9 years ago

Works for me now too. Thanks for fixing!