ignored globals in package.json

[nikmartin]

I added this to the package.json file in the root of my node.js app:

  "semistandard": {
    "global": [ "__base" ]
  }

and in hundreds of files in the project, I have this:

var util = require(__base + '/models/schemas/util');

But still continually get this message:

[sandnuggah]

{
  "semistandard": {
    "globals": [ "__base" ] // the key is `globals`, not `global`
  }
}

Restart Atom for changes to have effect.

[nikmartin]

OK, I couldn't find any docs, so I went to the source, lib/style-settings.js: 66 and found this: styleSettings.global = styleSettings.global || styleSettings.globals So I just took the first option global and used it.

[nikmartin]

Also, That didn't have any effect:

"semistandard": {
    "globals": [
      "__base"
    ]
  }

[sandnuggah]

Have a look here

https://github.com/feross/standard/blob/master/README.md#i-use-a-library-that-pollutes-the-global-namespace-how-do-i-prevent-variable-is-not-defined-errors

[nikmartin]

I don't know why it's not honoring the setting then, I have tried it both as:

"semistandard": {
    "globals": [
      "__base"
    ]
  }

and

"semistandard": {
    "global": [
      "__base"
    ]
  }

Restarting each time, and the warnings never go away.

[ricardofbarros]

Hey guys, thanks for your help @sandnuggah.

Hmm that's awkward, let me take a look.

[nikmartin]

If you need me to debug anything, let me know.

[ricardofbarros]

Can you do something for me? cd /to/the/directory/where/is/your/file and run semistandard yourFilename.js and tell me if it shows the same warning on the terminal.

[nikmartin]

In a file with only a single 'not defined' warning I get no warnings running semistandard on the command line. In a file with a 'not defined' + other warnings, I only get the other warnings.

[ricardofbarros]

What settings you have ticked on linter-js-standard plugin settings?

[nikmartin]

None are selected at the moment:

"linter-js-standard":
    style: "semi-standard"

[ricardofbarros]

Well if you want your style settings to be honoured you need to tick the Honor Style Settings

[ricardofbarros]

So did it worked?

[nikmartin]

I checked Honor Style Settings and it is working now. I took the README literally, and since it says:

Current style settings supported:
- `ignore`
- `parser`

I didn't think it applied to globals. Should I add some documentation about it and submit a pull request? I didn't even know how to add support for globals until I read the source code and the standard lib's readme.

[ricardofbarros]

Sure @nikmartin I would appreciate that :)

[ricardofbarros]

66 Merged, thanks for the PR @nikmartin