search

ricardofbarros / linter-js-standard

Atom linter plugin for JavaScript, using JavaScript Standard Style
https://atom.io/packages/linter-js-standard
MIT License
99 stars 48 forks source link

Getting warning for jsx on a regular js file #78

Closed FabioAntunes closed 7 years ago

FabioAntunes commented 8 years ago

screenshot from 2016-01-15 10 33 28

On all my es6 files file I'm getting this warning on the first line, although they have nothing to do with jsx

mrakow commented 8 years ago

Warning text (to make this issue easier to find via search):

Definition for rule 'react/jsx-no-duplicate-props' was not found (react/jsx-no-duplicate-props)at line 1 col 1

Only happens when using standard or semi-standard, not when using happiness. Occurs on all non-empty js files.

Maybe one can copy the happiness rule list over to the other lists.

jedthehumanoid commented 8 years ago

This is fixed in semistandard 7.0.3, so all that is needed for linter-js-standard is to update dependency to newer version

Pull request https://github.com/ricardofbarros/linter-js-standard/pull/76 solves this, but it has not been merged yet.

In the meantime, if you want to get rid of this, as a workaround you can change version of semistandard dependency in .atom/packages/linter-js-standard/package.json and do: 

npm install

in that directory (.atom/packages./linter-js-standard)

jedthehumanoid commented 8 years ago

Actually both of the open pull requests solves this.