search

ricardofbarros / linter-js-standard

Atom linter plugin for JavaScript, using JavaScript Standard Style
https://atom.io/packages/linter-js-standard
MIT License
99 stars 48 forks source link

Updated happiness #86

Closed wesleytodd closed 8 years ago

wesleytodd commented 8 years ago

We recently updated happiness to follow more closely with standard. So pinning a version shouldn't be as important, so I changed it to the most recent major version range. I dont have much experience with atom packages , so I don't know how to test it, but the api between standard@5.2.1 should be the same as happiness@5.5.0. If you have instructions on how I can run this branch on my atom install I would love to try to make sure it is all working. Unless you are confident it is alright. Thanks!

wesleytodd commented 8 years ago

Ping :)

ricardofbarros commented 8 years ago

Hey @wesleytodd sorry for the late reply, I'm currently undergoing a refactor of this package for the next major version to in way fix this type of problems, people will be able in the future to use a specific version of standard, semistandard, happiness, etc.. So that's why I'm not merging this, but thanks for the heads up, when I will release I will update the default versions and I surely will update thehappiness`default version to 5.5.0. Once again sorry for the late reply.

wesleytodd commented 8 years ago

Sounds awesome! Thanks for the update.

ricardofbarros commented 8 years ago

Hello @wesleytodd. Seems like a PR from @devTristan came first to address this issue.

So as now this is fixed on the latest release 3.3.0.

Thanks. But I will still update this package in the meantime with some new features.