search

ricardojmendez / UnitySteer

Steering, obstacle avoidance and path following behaviors for the Unity Game Engine
https://numergent.com/tags/unitysteer/
Other
1.21k stars 277 forks source link

Add direction noise fluctuation post-process #51

Open sinbad opened 7 years ago

sinbad commented 7 years ago

This is just like the speed fluctuation component but gives a little extra variance to final result which helps it look more natural.

BTW: hope you don't mind all these PRs, it's just my principle to contribute back changes I find useful even on MIT projects. There's no urgency to merge these from my perspective, I'm just sending them as I make them.

ricardojmendez commented 7 years ago

BTW: hope you don't mind all these PRs, it's just my principle to contribute back changes I find useful even on MIT projects. There's no urgency to merge these from my perspective, I'm just sending them as I make them.

Not at all! I'm glad you not only find it useful but contribute.

I hope you don't mind my delays in getting them reviewed and merged. This end of year is providing to be a bit overloading, so I've had to table anything non-fundamental for now.

I hope to get around to them before the end of the year, but in fact, let me just add you as a contributor.

Cheers!

ricardojmendez commented 7 years ago

There you go. Couple of requests:

Cheers!

sinbad commented 7 years ago

Thanks!

I'm using git-flow. Please make your changes on develop, we'll eventually do a release on master.

I only see a development branch rather than develop, I pointed all my PRs at that assuming that was the target, that OK? Since I'm still pretty new to this I'm happier submitting PRs rather than merging directly to development myself.

Keep a changelog.

Cool, I didn't know what your procedure was here, assumed Changelog.md got updated at release time since updating it for every PR tends to cause merge conflicts. Happy to update it for each PR though if you prefer.

When adding a feature, please provide an example using it on UnitySteerExamples

👍 given most of these are small refinements is it OK to tweak an existing sample to include it where appropriate?

I hope you don't mind my delays in getting them reviewed and merged.

Not at all, I'm not waiting on anything, I'm just submitting these as I go so I don't forget. I'm happy if I can add something back (and equally relaxed if you say something doesn't fit being upstream) but there's absolutely no rush since I'm using my modified copy. I'm very grateful for your work on this project and don't wish to give you more work to do! :) I won't be at all offended if these PRs sit in the queue until you have some free time, be that day, weeks, months, more or even never 😉

Thanks again!

ricardojmendez commented 7 years ago

I only see a development branch rather than develop, I pointed all my PRs at that assuming that was the target, that OK? Since I'm still pretty new to this I'm happier submitting PRs rather than merging directly to development myself.

You are right. I forgot that I named the one on UnitySteer before I switched naming to the more succinct develop :-)

Cool, I didn't know what your procedure was here, assumed Changelog.md got updated at release time since updating it for every PR tends to cause merge conflicts. Happy to update it for each PR though if you prefer.

Thanks! I usually just add to the changelog under a SNAPSHOT or WIP version. Such conflicts are easy enough to fix if we keep them to one line, one change.

given most of these are small refinements is it OK to tweak an existing sample to include it where appropriate?

Definitely!

Cheers!