search

ricardomaraschini / oomhero

Kubernetes sidecar for memory usage tracking
Apache License 2.0
108 stars 10 forks source link

Properly validate Warning and Critical #4

Closed ricardomaraschini closed 5 years ago

ricardomaraschini commented 5 years ago

We need to check if Warning and Critical are properly set. Rules are very simple:

  1. Warning and Critical must be lower or equal to 100;
  2. Warning must be lower or equal to Critical;

If conditions are not met, use the default values and notify through log.

vdepatla commented 5 years ago

@ricardomaraschini created this PR https://github.com/ricardomaraschini/oomhero/pull/9 for the change .. this is my first doing a PR on github let me know if something is missing or not linked ..

ricardomaraschini commented 5 years ago

Thanks for your PR @vdepatla, wish you all the best. You did good!