search

ricbra / php-discogs-api

PHP 5.4 Implementation of the Discogs API
MIT License
152 stars 96 forks source link

Inventory API Call #10

Closed davalb closed 10 years ago

davalb commented 10 years ago

Hi Ricbra,

first of all thanks for the awesome library. Helped me a lot to develop an app we use to synchronize the our webshop-inventory with our discogs-inventory.

I know that you generally don`t have any marketplace-API-calls implemented. I assume that it is because they require OAuth. Would you consider supporting the inventory-call? It is an exception in that it is a public call. Please see code changes attached.

Best regards, David

ricbra commented 10 years ago

Thanks for your PR. Could you also add a test for this new call?

davalb commented 10 years ago

How do you have setup the test-enviroment? If I run the tests in the command-line I get an error like "Class 'Discogs\Serivce` not found..." I guess the autoloader is not included... Or do you run the tests in the browser?

ricbra commented 10 years ago

Assuming you're developing on *nix: First get phpunit: $ wget https://phar.phpunit.de/phpunit.phar

Install all dependencies with composer: $ composer.phar install

Run the tests: $ php phpunit.phar .

davalb commented 10 years ago

Is this test ok?

ricbra commented 10 years ago

Thanks for your work!

davalb commented 10 years ago

Thank you for incorporating the changes. Will these changes be available through composer at some point? I am asking, because my app is using composer in the deployment process.

ricbra commented 10 years ago

@davalb I'll tag a new version