search

ricbra / php-discogs-api

PHP 5.4 Implementation of the Discogs API
MIT License
152 stars 95 forks source link

Should Fix php notice on default config params merge + Readme addition #44

Closed thomasmery closed 7 years ago

thomasmery commented 7 years ago

This is a PR to fix a php notice that appears when one tries to declare a custom defaults array where a key is used that is not present in the $defaultConfig array declared in the ClientFactory factory function

I've included a simple test but maybe that' s not enough

also added a non directly related change in the Readme to inform that the Discogs API allow for a simple auth mechanism - related to #43

let me know what you think and thanks for your work!

ricbra commented 7 years ago

Thanks @thomasmery

thomasmery commented 7 years ago

Hi @ricbra ,

I don't think you pushed this to packagist is it in the plans? or are you waiting for more significant changes? or is it not how it works? (not so familiar with the process)

asking because I have a project that would benefit from a version bump in its composer file for this library

I can of course make the change by hand

thanks

ricbra commented 7 years ago

I've just tagged a new release and pubished it on Packagist.