search

ricbra / php-discogs-api

PHP 5.4 Implementation of the Discogs API
MIT License
152 stars 96 forks source link

Added 'page' and 'per_page' parameters to 'search' - these are supported by Discogs API #54

Open Blackout opened 5 years ago

Blackout commented 5 years ago

https://www.discogs.com/developers/#page:database,header:database-search "Issue a search query to our database. This endpoint accepts pagination parameters"

ricbra commented 5 years ago

Hi @Blackout

Could you also add a unit test for this scenario?

Blackout commented 5 years ago

Sure

I've also added 'getPriceSuggestions' https://www.discogs.com/developers/#page:marketplace,header:marketplace-price-suggestions

Blackout commented 5 years ago

@ricbra how do i make unit tests?

froschdesign commented 5 years ago

@Blackout php-discogs-api uses PHPUnit. A complete documentation can be found under phpunit.de. Look also in the tests folder of this repository.

Blackout commented 5 years ago

Yeah no idea how to use PHPUnit. It works, you can see how simple the changes are. I'm using both changes now. Accept it or dont.