Closed corvus-ch closed 8 years ago
Thanks for the PR. I'm AFK this week, so I'll respond next week.
Op ma 25 jan. 2016 08:40 schreef Christian Häusler <notifications@github.com
:
There are use cases where a consumer script needs access to properties and headers of an AMQP message. For that purpose, I have added a flag. If this flag is set, it will change the payload passed to the script. This alternate payload will be a JSON encoded data structure containing not only
the body but also includes the messages properties and headers.
You can view, comment on, or merge this pull request online at:
https://github.com/ricbra/rabbitmq-cli-consumer/pull/23 Commit Summary
- Add include metadata flag
- Include message properties and headers
- Document how to include metadata
- Fix some typos
File Changes
- M README.md https://github.com/ricbra/rabbitmq-cli-consumer/pull/23/files#diff-0 (99)
- M consumer/consumer.go https://github.com/ricbra/rabbitmq-cli-consumer/pull/23/files#diff-1 (63)
- M main.go https://github.com/ricbra/rabbitmq-cli-consumer/pull/23/files#diff-2 (5)
Patch Links:
- https://github.com/ricbra/rabbitmq-cli-consumer/pull/23.patch
- https://github.com/ricbra/rabbitmq-cli-consumer/pull/23.diff
— Reply to this email directly or view it on GitHub https://github.com/ricbra/rabbitmq-cli-consumer/pull/23.
Hi @corvus-ch ,
This looks good to me. Thanks for your contribution!
@ricbra Do you think would be possible to merge it (#23 and #24) into 2.0? Thanks in advance!
Hi @skolodyazhnyy ,
Yes, it is definitely possible! The v2 version went a bit of my radar. Due to the fact I was quite busy and the lack of contributors to this project made me loss my motivation a bit. But last days PR make me a happy person, so I'm gonna invest some time to get v2 released as soon as possible.
There are use cases where a consumer script needs access to properties and headers of an AMQP message. For that purpose, I have added a flag. If this flag is set, it will change the payload passed to the script. This alternate payload will be a JSON encoded data structure containing not only the body but also includes the messages properties and headers.