search

ricbra / rabbitmq-cli-consumer

Consume RabbitMQ messages into any cli program
MIT License
247 stars 49 forks source link

Add delivery details to the JSON object #26

Closed skolodyazhnyy closed 8 years ago

skolodyazhnyy commented 8 years ago

I've added routing key to the properties array.

skolodyazhnyy commented 8 years ago

I've added routing_key to properties array, same as redelivered, although neither of those is valid property according to AMQP Spec, section 1.8.1. So, may be it would be better to move both these options outside of the properties array, for example into delivery_info as in php-amqplib.

skolodyazhnyy commented 8 years ago

Ok, I gave it some thinking and it seems logical to me to have all delivery details in the separate JSON property. Let me know what do you think.

skolodyazhnyy commented 8 years ago

/ping @ricbra

If you could find a moment to have a look into this PR and another one about exit codes would be great.

ricbra commented 8 years ago

Sorry for the delay @skolodyazhnyy

This one looks good to me. Thanks again for your work!