search

ricbra / rabbitmq-cli-consumer

Consume RabbitMQ messages into any cli program
MIT License
247 stars 49 forks source link

Dead queue and retry implementation #52

Open andrefigueira opened 7 years ago

andrefigueira commented 7 years ago

Hi @ricbra

I took the initial work @mjolt did and put in to the most up to date code. Do you reckon there is a chance of merging it in? I'd love to keep using the original codebase, and contributing, but really need this functionality. So if this isn't merged, then I'll probably just work off of the fork.

Tested for backwards compatibility, and all seems to work perfectly.

Let me know if you'll be merging and if you want me to change anything!

Thank you!

andrefigueira commented 7 years ago

Hi Again,

So I've been testing this extensively and spotted a bug in the original PR which caused dead queued items to not have their headers published correctly, have now resolved this in latest push.

Cheers

ricbra commented 7 years ago

Hi @andrefigueira

Thank you for your PR. I would love to get this in, but since there are no tests in the current master I'm very cautious on merging new stuff. A lot of people (including my previous company) are running this in production and I don't want to break things. I'm not using this library actively anymore and I don't have the time to put a lot of effort in it. So it would even be difficult to just compile and test your work.

I understand if you want to continue to work on your own fork. If you're interested in contributing perhaps you could take a look at the discontinued v2 rewrite. If you're not interested: no hard feelings 😄

andrefigueira commented 7 years ago

Hi @ricbra

No hard feelings at all! very grateful for the library to begin with! Wondering, if I were to include tests for everything would that help?

I'll take a look at V2 also! to see what's in it.

Thanks again