search

riccardoNovaglia / jbrains-pos

0 stars 0 forks source link

Function `receivedPrice` stores something that I don't consider a "price" #1

Open jbrains opened 6 years ago

jbrains commented 6 years ago

https://github.com/riccardoNovaglia/jbrains-pos/blob/5482f8ffb79e9e228b57eb3717fc6421ffcd0d8c/src/test/scala/pos/SingleItemSpec.scala#L51

What name would better describe what this function does?

riccardoNovaglia commented 6 years ago

I'm guessing by that you mean the priceDisplay.receivedPrice. You are right, I created the stub for the happy path and then never considered it would not only receive prices, but also random error messages, and never remembered to refactor.