riccardobertolini / lofi-music

Create your music while working/studying
https://www.lofimusic.dev
MIT License
45 stars 30 forks source link

Active/Stop all bar #66

Closed riccardobertolini closed 1 year ago

riccardobertolini commented 1 year ago

From this image

to this

image

which still should appear only when sounds are active

CSS example (just for reference)

transition: opacity 0.3s ease 0s;
opacity: 1;
cursor: default;
display: flex;
align-items: center;
gap: 20px;
position: absolute;
bottom: 0px;
justify-content: center;
width: 100%;
z-index: 100;
background: rgba(0, 0, 0, 0.8);
color: white;
font-family: "Ubuntu", sans-serif;
SubxX commented 1 year ago

I can work on this.

DavidKozdra commented 1 year ago

the changes in #69 would work well here as well what do you think @riccardobertolini

riccardobertolini commented 1 year ago

Yes, agree with you @DavidKozdra. Let's keep this one and in case #69 is finished first we can close both - thanks!

SubxX commented 1 year ago

I applied my own creativity and endup with this design. Please give me your feedback should I leave it like this or create the exact design provided.

Screenshot 2023-07-30 at 11 26 12 PM

I do have the given design ready in a separated branch so once I get a feedback from you I will create the appropiate PR Thanks

DavidKozdra commented 1 year ago

not bad, it might be nice as some thing you can move or toggle down, If its gonna be that small I would pick a corner and an Icon as well as the text to go with the button would be a nice touch but over all really nice, react has like a million draggable libraries

riccardobertolini commented 1 year ago

Looks great @SubxX! I feel this could go ahead and @DavidKozdra suggestions can come in a separate task. Thanks!

SubxX commented 1 year ago

Sorry for the delay guys got busy with office stuff xD anyway I have created a PR now and yes lets create a separate task for the suggestions.

riccardobertolini commented 1 year ago

No worries @SubxX thanks for your work, looks great!