search

riccardocescon / clean_chess

Lichess Client app made with Flutter
GNU General Public License v2.0
30 stars 7 forks source link

[p0] Minor code improvements #13

Open alexrintt opened 1 year ago

alexrintt commented 1 year ago

p0 stands for priority 0 (lowest).

1. Unnecessary Failure class

https://github.com/riccardocescon/clean_chess/blob/231c861c94c479f8165c77f540c7d0413389ff13/lib/chess/error/failures.dart#L1-L4

Dart has the Exception class to represent runtime errors and the Error class to represent development errors.

2. Fix all lint errors

Do not ignore lint rules.

https://github.com/riccardocescon/clean_chess/blob/231c861c94c479f8165c77f540c7d0413389ff13/lib/chess/utilities/constants.dart#L1