search

riccardocescon / clean_chess

Lichess Client app made with Flutter
GNU General Public License v2.0
30 stars 7 forks source link

Create oauth bloc #61

Closed alexrintt closed 1 year ago

riccardocescon commented 1 year ago

@alexrintt why you decided to use Cubit instead of Bloc?

alexrintt commented 1 year ago

@alexrintt why you decided to use Cubit instead of Bloc?

Simplicity: less boilerplate code, less classes, same result.

riccardocescon commented 1 year ago

@alexrintt is the last commit basically a merge with the [chesskit] branch? if so we can merge this to the main and start another branch for the implementations, and remove the chesskit branch

riccardocescon commented 1 year ago

Updated the AuthState with freezed states, give it a look, what do you think about working this way for cubit states?

alexrintt commented 1 year ago

seems unnecessary use of code generation, but i think it works.

riccardocescon commented 1 year ago

seems unnecessary use of code generation, but i think it works.

We use Freezed in order to get that .map in order to analyze the result instead of adding a lot of code Just to 'filter' the event

riccardocescon commented 1 year ago

So Will we be using this approach? Can we implement this ok the code already written and merge?