search

riccardoperra / codeimage

A tool to beautify your code screenshots. Built with SolidJS and Fastify.
https://codeimage.dev
MIT License
1.39k stars 73 forks source link

🚀 - GitHub Dark Dimmed Theme #449

Closed Desoroxxx closed 1 year ago

Desoroxxx commented 1 year ago

Which @codeimage/* package(s) are relevant/releated to the feature request?

highlight

Description

Currently only GitHub Dark theme is available, it would be perfect if GitHub Dark Dimmed was available!

riccardoperra commented 1 year ago

I will work on it this weekend 😄 Thanks

riccardoperra commented 1 year ago

Hey @JustDesoroxxx, I just added a preview for the github dark dimmed theme here https://codeimage-app-pr-450.vercel.app/ with #450 pr. If something is missing in your opinion just telI me, I will deploy it once is ok

Desoroxxx commented 1 year ago

There is just a little problem that you can see here:

image

image

Other than that, looks awesome!

riccardoperra commented 1 year ago

I've updated the variable and token colors, but for now I want to differentiate the type keyword image

Also, void is considered a keyword by the java lezer parser so the color will not change at the moment.

I've also found that I currently have no way to differentiate properties from function methods

I need to figure out in the future how to extend the parser to handle more cases. Now I prefer to leave it as it is. probably these problems are solved if i add the textmate grammar instead of lezer, but don't know if it's supported