riccardoperra / codeimage

A tool to beautify your code screenshots. Built with SolidJS and Fastify.
https://codeimage.dev
MIT License
1.33k stars 72 forks source link

Merge next in main #493

Closed riccardoperra closed 1 year ago

riccardoperra commented 1 year ago

This branch contains some updates for the API rest

Breaking changes

Must be merged with:

codesandbox[bot] commented 1 year ago

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 85f9975a797f069562aaafd1b87ad44a9f8efa45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | -------------- | ----- | | @codeimage/app | Minor | | @codeimage/api | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 year ago

Deploy preview for codeimage-ui-dev ready!

✅ Preview https://codeimage-ui-recpnj4wi-riccardoperra.vercel.app https://codeimage-ui-pr-493.vercel.app

Built with commit d9eb8f812d64ec8a45b5e0295f3185ac5908623b. This pull request is being automatically deployed with vercel-action

github-actions[bot] commented 1 year ago

Deploy preview for codeimage-highlight-dev ready!

✅ Preview https://codeimage-highlight-5ucy21uxd-riccardoperra.vercel.app https://codeimage-highlight-pr-493.vercel.app

Built with commit 69210bb51ac57820e8f00cc05ad648418ea2b292. This pull request is being automatically deployed with vercel-action

github-actions[bot] commented 1 year ago

Deploy preview for codeimage-website-dev ready!

✅ Preview https://codeimage-website-ei9vxg4mw-riccardoperra.vercel.app https://codeimage-website-pr-493.vercel.app

Built with commit 69210bb51ac57820e8f00cc05ad648418ea2b292. This pull request is being automatically deployed with vercel-action

github-actions[bot] commented 1 year ago

Deploy preview for codeimage ready!

✅ Preview https://codeimage-pxbfp3ehy-riccardoperra.vercel.app https://codeimage-app-pr-493.vercel.app

Built with commit 69210bb51ac57820e8f00cc05ad648418ea2b292. This pull request is being automatically deployed with vercel-action

riccardoperra commented 1 year ago

@hackpirodev We need to update the delete API in order to return an empty body instead of null.

Reproducible at next.codeimage.dev

image image

riccardoperra commented 1 year ago

@hackpirodev Currently the name property is mandatory and in both BE and FE side the empty string is allowed.

image

image

We should add a validation logic for backend using typebox and we have to display an error message on the dialog if it doesn't meet any criteria.

CodeUi is supporting the property validationState and errorMessage in order to show the content

https://codeui.netlify.app/text-input image

riccardoperra commented 1 year ago

EDIT: Fixed

@hackpirodev I don't know why but seems that in the build files vite is removing the presets properties even they are present on the CI

image image

currently there is no limits even if I set 5 for guest and 10 for loggedin users

riccardoperra commented 1 year ago

@hackpirodev rename action seems now broken, probably due to the refactor for both Dialog and RenameContentDialog component

https://user-images.githubusercontent.com/37072694/234764565-f0372390-03cf-48df-9c8b-6fdd719b8607.mp4

riccardoperra commented 1 year ago

On mobile iOS safari spaces could be broken, and the scrollbar seems to be under the card content

riccardoperra commented 1 year ago

EDIT: fixed

Select value binding for the syntax highlighting options are now broken

riccardoperra commented 1 year ago

CodeImage logo Text in light mode is still white

riccardoperra commented 1 year ago

Opening the preset the first time will always trigger the “update flow” calling the API.

we should enter in that flow only after an user input change.

This could be a statebuilder/commands issue

https://user-images.githubusercontent.com/37072694/234765753-9903b05a-7029-464f-9f4b-3faf744ed2d4.mp4

riccardoperra commented 1 year ago

Select value binding for the syntax highlighting options are now broken

riccardoperra commented 1 year ago

@hackpirodev I don't know why but seems that in the build files vite is removing the presets properties even they are present on the CI

image image

currently there is no limits even if I set 5 for guest and 10 for loggedin users

Seems fixed with latest deploy