search

riccqi / pe

1 stars 0 forks source link

Inconsistent error message when finding suppliers #11

Open riccqi opened 1 year ago

riccqi commented 1 year ago

Screenshot 2022-11-11 at 5.07.36 PM.png Screenshot 2022-11-11 at 5.07.36 PM

When executing find n/ hello to find a supplier with hello in the name, the error message instead refers to the found suppliers as 'persons'.

This is inconsistent and can be confusing for users, especially since the listSuppliers command refers to them as suppliers, not persons. Screenshot 2022-11-11 at 5.09.06 PM.png

I would expect all reference to suppliers to show "suppliers" instead of the default AB3 persons.

nus-se-script commented 1 year ago

Team's Response

I agree that all reference to suppliers should show "suppliers" instead of "persons". However, it is a typo and purely cosmetic issue in the UI and it does not affect the normal operations of the application usage at all. Hence I propose that the original severity of medium is too high and change it to veryLow.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]