Editing a stock will show success message even when the item is not updated

[riccqi]

When executing the editStock command and if the current stock is already at 7, editStock 1 c/7 which basically does not change the stock item at all will still show a success message, despite the item not being updated at all as the stock number is still 7.

I would expect the app to tell me that the item has not been updated, as the new details provided are the same as before. This will be unintuitive to users, who might wonder what the stock number was before the item was edited, without realising it is actually the same number.

[soc-pe-bot]

Team's Response

Response

• This is indeed intended behavior.
• Item is still replaced with the value that you have provided, and the claim that "this will be unintuitive to user..." seems over-exaggerated.

  Items for the Tester to Verify

  :question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: The fact is that the entity is not updated, because the values are the same. The app outputting the success message as "Stock updated" is misleading to the user and is definitely unintuitive in my opinion. When a user does something like editing a stock to be the same it currently is, it makes no sense. Thus it is definitely possible for them to have made a mistake entering the wrong index of the stock they want to edit, in which case the app should be responsible for telling the user about this oddness in their command.

I think the team should hold their app to higher standards and not reject issues that can clearly make the app better. Hence, I marked this issue as a FeatureFlaw, and not a bug.

---

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

• [ ] I disagree

Reason for disagreement: [replace this with your explanation]

---