sjbradshaw
commented
6 years ago The atomic data will be needed if solving for the non-equilibrium ionization state, but de-coupled from the radiation calculation and using the power-law radiative losses.
From: Will Barnes notifications@github.com Sent: Wednesday, April 11, 2018 11:57 AM To: rice-solar-physics/HYDRAD HYDRAD@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [rice-solar-physics/HYDRAD] Don't require atomic data when using the power-law option for the radiative losses (#11)
When using the power-law radiative loss option, no atomic data is required for the calculation (I think??). However, when the Radiation object is initialized, atomic data is read from Radiation_Model/atomic_data even when using the power-law option.
It would be convenient if this data was not required when using the power-law option. This is particularly useful when doing many (hundreds or thousands) HYDRAD and/or Initial Conditions as it means that the atomic data (which is by far the largest percentage of the repo) can be left out of the folder when copying the code repeatedly. This would make the setup of many runs much quicker as the atomic data is rather
Unless this data is used elsewhere (even when selecting the power-law option), I think it would just be a matter of adding something like this to the Radiation constructor,
CRadiation::CRadiation( char *szFilename) {
ifndef USE_POWER_LAW_RADIATIVE_LOSSES
Initialise( szFilename );
endif
}
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rice-solar-physics/HYDRAD/issues/11 , or mute the thread https://github.com/notifications/unsubscribe-auth/AIXhfgwcIF84RCwheBUgakn0C7BG9l2kks5tnjX1gaJpZM4TQZYe . https://github.com/notifications/beacon/AIXhfmYGr7ymV9wMQtHtRyNNxVtYmPVOks5tnjX1gaJpZM4TQZYe.gif
wtbarnes
When using the power-law radiative loss option, no atomic data is required for the calculation (I think??). However, when the Radiation object is initialized, atomic data is read from
Radiation_Model/atomic_dataeven when using the power-law option.It would be convenient if this data was not required when using the power-law option. This is particularly useful when doing many (hundreds or thousands) HYDRAD and/or Initial Conditions as it means that the atomic data (which is by far the largest percentage of the repo) can be left out of the folder when copying the code repeatedly. This would make the setup of many runs much quicker as the atomic data is rather
Unless this data is used elsewhere (even when selecting the power-law option), I think it would just be a matter of adding something like this to the Radiation constructor,