rice-solar-physics / ebtelplusplus

An implementation of the enthalpy-based thermal evolution of loops (EBTEL) model implemented in C++ and wrapped in Python
https://ebtelplusplus.readthedocs.io
GNU General Public License v3.0
11 stars 5 forks source link

Add effects due to area expansion #81

Closed rowancllzz closed 2 months ago

rowancllzz commented 11 months ago

Fixes #58

This pull request implements changes to the two-fluid EBTEL equations to account for cross-sectional area expansion following the methodology of Cargill et al. (2022). This PR represents a substantial modification to ebtel++ and includes the following changes:

Additionally, this PR also includes several minor modifications:

wtbarnes commented 7 months ago

These files are the spatially-averaged HYDRAD results I've been using for benchmarking. I'm preserving them here to remember what we used to test these new additions against.

no_expansion_electron.txt no_expansion_ion.txt no_expansion_single_fluid.txt q1_tanh_electron_trac.txt q1_tanh_ion.txt q1_tanh_single_fluid.txt

wtbarnes commented 7 months ago

See this gist for an example of some of this benchmarking: https://gist.github.com/wtbarnes/ef4b6401d100399503a956be1d038b5c

wtbarnes commented 2 months ago

I verified that the C++ and IDL results match one another to an acceptable degree and that any remaining differences are not due to this PR. The generic differences between this code and the IDL version are being tracked in #40.