search

rice-solar-physics / pydrad

Python tools for setting up HYDRAD runs and parsing output
https://pydrad.readthedocs.io
MIT License
4 stars 3 forks source link

Fix beam heating and OpenMP options #164

Closed wtbarnes closed 9 months ago

wtbarnes commented 9 months ago

This pull request contains two major bugfixes:

  1. Add full support for parallelized runs with OpenMP (Fixes #163, Fixes #152)
  2. Fixes a bug when using the beam heating option by adding the BEAM_HEATING directive to the necessary header file.

Additionally, this PR also contains a few other more minor fixes:

  1. The compiler script is now configured at runtime. This makes it easier to specify a compiler besides g++. Flags (e.g. for optimization) can also be optionally passed in.
  2. The run_shell_command function now just takes in a path (Fixes #162)
  3. There are now a few additional tests for running HYDRAD with different options. These are just "smoke tests" to ensure that certain combinations of config parameters don't lead to unexpected behavior.
codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (52a9666) 66.85% compared to head (5a96f65) 68.48%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #164 +/- ## ========================================== + Coverage 66.85% 68.48% +1.62% ========================================== Files 11 11 Lines 694 714 +20 ========================================== + Hits 464 489 +25 + Misses 230 225 -5 ``` | [Files](https://app.codecov.io/gh/rice-solar-physics/pydrad/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rice-solar-physics) | Coverage Δ | | |---|---|---| | [pydrad/configure/configure.py](https://app.codecov.io/gh/rice-solar-physics/pydrad/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rice-solar-physics#diff-cHlkcmFkL2NvbmZpZ3VyZS9jb25maWd1cmUucHk=) | `84.21% <100.00%> (+3.62%)` | :arrow_up: | | [pydrad/configure/util.py](https://app.codecov.io/gh/rice-solar-physics/pydrad/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rice-solar-physics#diff-cHlkcmFkL2NvbmZpZ3VyZS91dGlsLnB5) | `89.65% <100.00%> (+1.72%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/rice-solar-physics/pydrad/pull/164/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rice-solar-physics)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.