Closed jwreep closed 8 months ago
Oof yeah this is broken on all OSes for local copies of HYDRAD. It seems that distutils.copy_tree
does not support Pathlib
objects. The linked PR removes this in favor of just using shutil.copytree
instead which should fix this. I've also added a test to avoid future breakages.
Ok This should be fixed. Pull down the latest changes and let me know if this still persists and feel free to reopen if so!
Looks good. Thanks, Will!
It did throw a warning, but possibly that's expected?
>>> get_clean_hydrad(copy, base_path=base)
WARNING: Cannot remove .git. Directory not found. [pydrad.configure.util]
I'm on Windows 10, with a fresh install of pydrad. Here's a simple example of trying to make a copy of the HYDRAD folder, which doesn't work.
However, copying it from Github does work:
The issue seems to boil down to
distutils.dir_util.copy_tree
, and it looks like it's because it's having trouble creating the new folder.The following works fine, but it just copies everything directly to the Desktop.