Open wtbarnes opened 3 weeks ago
Attention: Patch coverage is 75.90361%
with 40 lines
in your changes missing coverage. Please review.
Project coverage is 71.30%. Comparing base (
557e41a
) to head (43bfc03
).
Files with missing lines | Patch % | Lines |
---|---|---|
pydrad/parse/util.py | 60.00% | 18 Missing :warning: |
pydrad/parse/parse.py | 88.28% | 13 Missing :warning: |
pydrad/configure/configure.py | 10.00% | 9 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes #86
This pull requests does a few things though is mainly focused on refactoring the parsing of the results files to try and simplify things:
pydrad/parse/util.py
that returnastropy.table.QTable
objects rather than arraysStrand
are only dynamically generated if there are many of them or if they are unknown ahead of time (e.g. for the.ine
files). Otherwise they are explicitly listed onProfile
..amr
files. If the.phy
files are not read (or not present), the thermodynamic quantities are computed from the conserved quantities in the.amr
files. See #86.TODOs:
Profile
.amr
file has an additional column for the electron mass density