search

rice-solar-physics / pydrad

Python tools for setting up HYDRAD runs and parsing output
https://pydrad.readthedocs.io
MIT License
4 stars 3 forks source link

Remove tabulated gravity and cross-section file names from config dictionary #50

Closed wtbarnes closed 5 years ago

wtbarnes commented 5 years ago

Currently there are separate options for tabulated_gravity_profile and tabulated_gravity_file. If tabulated_gravity_profile exists, tabulated_gravity_file is added to the config dictionary. There really is no need for this as the tabulated gravity filename is hardcoded anyway. In the template, there should just be a check for the existence of the tabulated_gravity_profile key and it is there, use the hardcoded tabulated.gravity filename.

All of this applies to the variable cross-section as well.

sjbradshaw commented 5 years ago

The tabulated_gravity (and tabulated_cross_section) pre-processor directives in HYDRAD are now defunct and replaced with USE_POLY_FIT_TO_GRAVITY and USE_POLY_FIT_TO_MAGNETIC_FIELD; this is because tabulated values are no longer used for either of these quantities. Instead, polynomial (6th order) fits are made and evaluated to find g(s) and B(s).

From: Will Barnes notifications@github.com Sent: Saturday, September 29, 2018 4:43 PM To: rice-solar-physics/hydrad_tools hydrad_tools@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [rice-solar-physics/hydrad_tools] Remove tabulated gravity and cross-section file names from config dictionary (#50)

Currently there are separate options for tabulated_gravity_profile and tabulated_gravity_file. If tabulated_gravity_profile exists, tabulated_gravity_file is added to the config dictionary. There really is no need for this as the tabulated gravity filename is hardcoded anyway. In the template, there should just be a check for the existence of the tabulated_gravity_profile key and it is there, use the hardcoded tabulated.gravity filename.

All of this applies to the variable cross-section as well.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rice-solar-physics/hydrad_tools/issues/50 , or mute the thread https://github.com/notifications/unsubscribe-auth/AIXhfvJGM8479U1FP56f5EXqmlFvQPzZks5uf-lUgaJpZM4XAssJ . https://github.com/notifications/beacon/AIXhfq4jGZ4PritXBx_CIaCOZI52Ok7vks5uf-lUgaJpZM4XAssJ.gif