search

rice-solar-physics / pydrad

Python tools for setting up HYDRAD runs and parsing output
https://pydrad.readthedocs.io
MIT License
4 stars 3 forks source link

Two new preprocessor directives added to HYDRAD #91

Closed jwreep closed 4 years ago

jwreep commented 4 years ago

define USE_SINGLE_VALUE_DECOMPOSITION

define USE_LOWER_UPPER_DECOMPOSITION

The two are mutually exclusive. Only one can be defined. This specifies which decomposition (SVD or LU) to use for the NLTE_CHROMOSPHERE.

wtbarnes commented 4 years ago

Thanks! Which file should these go into? RadiationModel/source/config.h? HYDRAD/source/config.h?

jwreep commented 4 years ago

They're actually in Radiation_Model/OpticallyThick/RadiativeRates.h

On second thought, maybe pydrad need not ever change these. They're essentially specifying detailed numerics that the average user might not care about.

wtbarnes commented 4 years ago

If it's a possible input parameter, it's worth adding as another config option. It's easy enough to add a template for RadiativeRates.h. Is there any reason these options couldn't be in one of the more "standard" config header files?

jwreep commented 4 years ago

In principle they could be, but they're not used by any of the rest of the code and they probably shouldn't be modified unless you know what they do.

sjbradshaw commented 4 years ago

The SVD code will eventually be deprecated and removed. These two defines are only for internal purposes (testing, benchmarking, debugging). The end user will never see them and they will be removed with the SVD code.

From: Will Barnes notifications@github.com Sent: Friday, February 7, 2020 3:59 PM To: rice-solar-physics/pydrad pydrad@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [rice-solar-physics/pydrad] Two new preprocessor directives added to HYDRAD (#91)

If it's a possible input parameter, it's worth adding as another config option. It's easy enough to add a template for RadiativeRates.h. Is there any reason these options couldn't be in one of the more "standard" config header files?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rice-solar-physics/pydrad/issues/91?email_source=notifications&email_token=ACC6C7TNL7Z4MCIMSX3KPJDRBXKSFA5CNFSM4KRQEH5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELEYW7Q#issuecomment-583633790 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACC6C7RZG2GE4SCP4CTO7WLRBXKSFANCNFSM4KRQEH5A . https://github.com/notifications/beacon/ACC6C7SPJYCV56LMSBLGURLRBXKSFA5CNFSM4KRQEH5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELEYW7Q.gif

wtbarnes commented 4 years ago

Alright then. Won't worry about it here!