search

rice-solar-physics / pydrad

Python tools for setting up HYDRAD runs and parsing output
https://pydrad.readthedocs.io
MIT License
4 stars 3 forks source link

NEQ Radiation flag logic does not allow power-law losses and decoupled solver #98

Closed wtbarnes closed 4 years ago

wtbarnes commented 4 years ago

In the current setup, you can either use the power-law radiative losses or non-equilibrium radiation, but not both. This makes sense except when one wants to solve for the non-equilibrium populations and decouple this calculation from the hydro code (i.e. not fold these back into the radiative loss calculation).

Need to modify the if-else statement in the radiation config template to account for this option. Also need to double check the actual HYDRAD code to make sure that setting non-equilibrium radiation flat does not automatically imply that these will be folded back into the radiative losses.

Also, should resolve this after or alongside #95

wtbarnes commented 4 years ago

Also, the spelling of the decoupling flag is incorrect in pydrad w.r.t. the actual code. I'm setting DECOUPLE_IONIZATION_STATE_SOLVER, but HYDRAD is looking for DECOUPLE_IONISATION_STATE_SOLVER.