ricepattyk / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

html sections #2

Open rimmesbe opened 7 years ago

rimmesbe commented 7 years ago

I like that you split up the html into sections using divs. However blank divs with no attribute selectors aren't all that useful. I would move the id's from the h2's into the divs instead. This way the id labels the section and makes each section uniquely targetable.

brushes h2 { }

https://github.com/ricepattyk/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/index.html#L10-L15

ricepattyk commented 7 years ago

Noted thanks. I did this originally but the changes weren't showing up on the browser, which I think was because I had linked to the root path, per your first point.