search

ricepattyk / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

good use of class #5

Open rimmesbe opened 7 years ago

rimmesbe commented 7 years ago

This is a good use of class and a good class name. I'd also consider using a <strong> tag here to add semantic value and default bold styling.

https://github.com/ricepattyk/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/resources/css/style.css#L31-L34

ricepattyk commented 7 years ago

Do you mean adding this to CSS:

.strong { font-weight: bold; }

And then on the HTML file, adding:

Or do you mean adding the tag directly in the HTML instead of making the change on CSS?

rimmesbe commented 7 years ago

replace the span with a strong tag, and remove the bold from the css.

On Tue, Aug 8, 2017 at 9:26 PM, ricepattyk notifications@github.com wrote:

Do you mean adding this to CSS:

.strong { font-weight: bold; }

And then on the HTML file, adding:

Or do you mean adding the tag directly in the HTML instead of making the change on CSS?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ricepattyk/prj-rev-bwfs-dasmoto/issues/5#issuecomment-321126312, or mute the thread https://github.com/notifications/unsubscribe-auth/AJfw_B2QKnWAhHA7zP4PUuE7GFL_LcRoks5sWQrHgaJpZM4OvocA .