search

ricewind012 / win95-themes

44 stars 0 forks source link

Wrong colors on Windows 11 with dark mode enabled #5

Closed DryTaste closed 2 months ago

DryTaste commented 2 months ago

As the title states; the theme exhibits the wrong (or rather unadvertised) colours when windows dark mode is turned on.

Sadly Windows doesn't have an exclude programs feature from it's dark mode, not sure if this is a feature request i should raise for this theme or for millennium.

ricewind012 commented 2 months ago

is it light when dark mode is enabled ? steam seems to ignore it on linux (and probably on windows too), that's why

DryTaste commented 2 months ago

is it light when dark mode is enabled ? steam seems to ignore it on linux (and probably on windows too), that's why

Uh, well, it looks like this;

Screenshot 2024-06-21 171650

Which i thought was unintended behaviour as it isn't shown anywhere on the screenshots. But your comment implies this dark mode is intended? Can i disable this intended behaviour? It seems like if i restart steam it starts out in light mode with the settings being in dark mode which is kinda weird but is in line with what you mentioned.

ricewind012 commented 2 months ago

It's intended if system dark mode is enabled, but steam is a special case. I do have plans on making it optional in some way, but for now you can disable auto-updates and remove the following: https://github.com/ricewind012/win95-themes/blob/master/dist/steam/steam.css#L92-L113 it should be located in c:\program files (x86)\steam\steamui\skins\win95-themes-master\dist\steam

DryTaste commented 2 months ago

It's intended if system dark mode is enabled, but steam is a special case. I do have plans on making it optional in some way, but for now you can disable auto-updates and remove the following: https://github.com/ricewind012/win95-themes/blob/master/dist/steam/steam.css#L92-L113 it should be located in c:\program files (x86)\steam\steamui\skins\win95-themes-master\dist\steam

Thank you for the fast reply and solution! Adding an option for it in millennium would be nice yeah. (but tbh windows should just have an exclude applications from dark mode option if you ask me)

ricewind012 commented 2 months ago

it will be optional only because the behavior doesn't really align with vs code (and soon discord) either