rich-iannone / DiagrammeR

Graph and network visualization using tabular data in R
https://rich-iannone.github.io/DiagrammeR/
Other
1.68k stars 247 forks source link

Use `cli::cli_abort()` everywhere. #502

Closed olivroy closed 8 months ago

olivroy commented 8 months ago

I also refactored some tests.

I found a test that was failing silently. I will attempt to find the root in a subsequent PR.

I found that some defunct functions were still used in certain places as well.

olivroy commented 8 months ago

@rich-iannone I see there are many issues open. If you want, I could try cleaning it up a little to cleanup a little to make further development a little easier?

rich-iannone commented 8 months ago

@olivroy that would be great, thank you! Also, before we merge this PR, would you be okay with adding yourself as an author to the package?

olivroy commented 8 months ago

Thank you! :) Done!