search

rich-iannone / DiagrammeR

Graph and network visualization using tabular data in R
https://rich-iannone.github.io/DiagrammeR/
Other
1.7k stars 248 forks source link

correct conditions #504

Open olivroy opened 10 months ago

olivroy commented 10 months ago

Not sure what the implications are of that.

Doesn't seem to affect tests. but I thought I'd single those out as they could influence the condition checking.

The first 1 is trivial. but maybe the conditions in traversals could influence some calculations.

Edit: If you have an idea for a test, I wouldn`t mind adding on. The coverage suggests the cases were not covered before and after this change https://app.codecov.io/gh/rich-iannone/DiagrammeR/pull/504/blob/R/trav_in_until.R

I added another change, but let me know if you think it is correct or not, maybe you only meant to test for length(from_column)?

rich-iannone commented 10 months ago

Sorry for the delay on this. And thanks for fixing these crazy statements! I have to revisit this soon to see if this still works as intended with the fix. It could indeed be that the bugged version works and there's not enough testing to see if the fixes here result in a regression.