search

rich-iannone / splitr

Use the HYSPLIT model from inside R and do more with it
Other
141 stars 60 forks source link

Extended_met with implicit exec_dir + system architecture #25

Open odrans opened 6 years ago

odrans commented 6 years ago

Hi Rich,

first, thanks a lot for this great R interface to HYSPLIT, it's really useful! I've just noticed a very minor issue when using extended_met = TRUE together with an implicit exec_dir. This configuration return

Error in file(con, "r") : cannot open the connection

An easy fix would be to replace l.157 in hysplit_trajectory.R :

if (extended_met) {
setup_cfg <- readLines('SETUP.CFG')  
[...]
 }

by

if (extended_met) {
    setup_cfg <- readLines(paste0(exec_dir, "/", "SETUP.CFG"))
[...]
  }

Another small thing I've noticed concerns the system architecture. It's great that you provide amd64 and x86 HYSPLIT versions for Linux but it took me some time to realize it while struggling with the required libraries. It could be useful to indicate in the README that one should adapt this to their systems by editing the R code.

Thanks again for all the great work!

Cheers, Odran

rich-iannone commented 5 years ago

The issue with the reading should be fixed now. And you’re right, a README improvement talking about the bundled executables should be done!