search

rich-iannone / splitr

Use the HYSPLIT model from inside R and do more with it
Other
141 stars 60 forks source link

multiple instances of "add_source" does not work #58

Open ghost opened 3 years ago

ghost commented 3 years ago

When I include multiple instances of "add_source" in the dispersion models, only the last instance is included in the output. The workaround has been to do each in its own call to run_model(), but that seems inefficient.

AlFontal commented 11 months ago

Hey @kpmessier, I don't know if this was changed after you mentioned your issue, but what the code seems to do now is to generate a single CONTROL file for each source, and iterate over the run_model() once for each source.

It's really inefficient for sure... At least compared to running it with the GUI with a single CONTROL file, which the syntax allows. I might try to change it in a PR but I am crazy busy right now...

Did you find any solution to the issue seeing that you posted it almost 3 years ago?

kyle-messier commented 11 months ago

Hi @AlFontal Due to the inactivity of this package, I was forced to explore other options. I have a postdoc working with me on scalable dispersion (and advection) modeling with PINNs.