search

rich-iannone / splitr

Use the HYSPLIT model from inside R and do more with it
Other
141 stars 60 forks source link

[defunct] bugfixes incl. issue #57 #69

Closed MRPHarris closed 3 years ago

MRPHarris commented 3 years ago

Two fixes: 1) start time-hours not indexed properly in hysplit_trajectory control file write loop, leading to weird behaviour when running trajectories. 2) locale handling in get_met_gdas1 was throwing up errors for some windows users. Fix integrated as per issue #57

MRPHarris commented 3 years ago

Quick comment before I close pull request, as it doesn't quite do what I had hoped:

This locale fix is partially working around code modified in response to pull request #52. This was included in #56. That fix forced the locale to be set to one only valid on non-windows machines (see https://www.rdocumentation.org/packages/base/versions/3.6.2/topics/locales).

The fix as I have made it will solve errors that relate to issue #57, but unfortunately it looks like, on some further tinkering, they will subsequently create issues for users in non-English locales. This seems to be what caused the problems for user ISOWater https://github.com/rich-iannone/splitr/issues/57#issuecomment-853773834, where a non-english month name was re-introduced as a result of my fix.

I'll come up with a fix that solves both the problems. Shouldn't take long.