richClubb / python-uds

A uds library for python
MIT License
97 stars 55 forks source link

Comments on DecodeFunctions.py #11

Open beckyc567 opened 6 years ago

beckyc567 commented 6 years ago

DecodeFunctions.py

def stringToIntList(aString, encodingType): result = [] [result.append(ord(i)) for i in aString] return result

... rather than ..

def stringToIntList(aString, encodingType): return [ord(i) for i in aString]

... or ...

def stringToIntList(aString, encodingType): result = [ord(i) for i in aString] return result
... i.e. in the event that you might want to use the intermediate result before returning?