Comments on TpFactory.py

richClubb / python-uds

A uds library for python

MIT License

97 stars 55 forks source link

Closed beckyc567 closed 6 years ago

beckyc567 commented 6 years ago

TpFactory.py

does the class only ever have a single static method? (other than what's inherited from object)
line 48: calling a static method "create" which doesn't appear anywhere? - a mistake or something in python I've not seen before? Looks like it should be calling "tpFactory('CAN')"?
otherwise looks OK

richClubb commented 6 years ago

Good review. I will have to revise the factory method as I'm not fully sure I'm actually implementing factories

richClubb commented 6 years ago

refactored the class to use the call method for creating the actual instances. I think this provides a nicer interface.