Comments on CanTp.py - Githubissues

richClubb / python-uds

A uds library for python

MIT License

97 stars 55 forks source link

Closed beckyc567 closed 6 years ago

beckyc567 commented 6 years ago

CanTp.py

for the condition on line 125 to make sense after line 121, presumably one of the above flows can update the state to END_OF_BLOCK - seems likely but just checking, and it may be worth a comment? ... if you can add one at line 70, then you can add one here
other than usual comments, it otherwise looks good.

richClubb commented 6 years ago

CanTp has some larger deficiencies and the CanTp and CanTpMessage structure seems to be a bad choice.

This needs to be fully re-factored to get rid of the CanTpMessage interaction and use a single CanTp class

richClubb commented 6 years ago

CanTp has been heavily refactored and this comment is no longer valid. May need a re-assessment