richClubb / python-uds

A uds library for python
MIT License
95 stars 54 forks source link

Implementation of multiple DID input to RDBI method #29

Open richClubb opened 5 years ago

richClubb commented 5 years ago

The ISO-14229 standard defines that the RDBI service should support querying multiple DIDs. This is a valid enhancement to the RDBI method

beckyc567 commented 5 years ago

RDBI with multiple DIDs is now supported. Code changes have been merged back down to the master branch. Four positive test cases have been provided and run (on the merged master) - these test cases demonstrate: basic read with 1 attribute returned; basic read with 2 attributes returned; multiple DID read with both single and multiple attributes for the two DIDs requested; the same again, but with different DID ordering. Negative test cases have not yet been developed.

beckyc567 commented 5 years ago

Additional test cases have been added to cover positive testing of the negative response cases - this required a minor fix. Negative test cases (e.g. handling of an invalid negative response), has not been added yet (currently considered low priority).