search

richClubb / python-uds

A uds library for python
MIT License
97 stars 55 forks source link

Refactor to proper PEP standards #55

Open RoninDusette opened 4 years ago

RoninDusette commented 4 years ago

While for sure a great piece of work, it needs a major refactor for legibility. It currently "pisses into the wind" of the standards in place for formatting functions/methods, classes, spacing is inconsistent, as much as it can be for a space delineated language. It sucks that it would need it, but would likely only take a weekend to do so. I am guessing you came from a Java background (just because of the formatting).

I am not talking trash, I am just saying that most IDEs will autoformat most of it to the standards of the language in context. Go with it, not against.

richClubb commented 4 years ago

I appreciate the feedback :) I started on C so you had a good first shot.

I'll definitely put it on the list of improvements as I'm seeing some more traffic on this project than I used to.