richClubb / python-uds

A uds library for python
MIT License
95 stars 54 forks source link

Callback for 0x78 Pending response #60

Open mamert opened 3 years ago

mamert commented 3 years ago

"pending" responses are silently ignored.

I have a branch which adds a callback triggered whenever they're received: https://github.com/mamert/python-uds/tree/callback_for_0x78_pending

e.g. :

def samplePendingCallback(msg):
    print(f"0x78 Pending received while waiting for response to {msg}")

uds_bus = Uds(reqId=req_id, resId=res_id, defaultPendingCallback=samplePendingCallback)  # for every call
# OR
response = uds_bus.send([0x22, 0xF1, 0x86], pendingCallback=samplePendingCallback)  # just this one

I wanted to ask if this is worth creating a PR for (since It's a niche thing), and if so, where to put an example

richClubb commented 3 years ago

Sorry. I've not been very good at maintaining this. I'll try to look at this this week.

On Wed, 13 Jan 2021 at 15:41, Mamert notifications@github.com wrote:

"pending" responses are silently ignored.

I have a branch which adds a callback triggered whenever they're received: https://github.com/mamert/python-uds/tree/callback_for_0x78_pending

e.g. :

def samplePendingCallback(msg): print(f"0x78 Pending received while waiting for response to {msg}")

uds_bus = Uds(reqId=req_id, resId=res_id, defaultPendingCallback=samplePendingCallback) # for every call

OR

response = uds_bus.send([0x22, 0xF1, 0x86], pendingCallback=samplePendingCallback) # just this one

I wanted to ask if this is worth creating a PR for (since It's a niche thing), and if so, where to put an example

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/richClubb/python-uds/issues/60, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMQRVGPQBV6HICRECM5ULLSZW5I5ANCNFSM4WA7X5KQ .

aaknitt commented 3 years ago

The ability to extend the receive timeout based on reception of a 0x78 Pending would be useful.