search

richClubb / python-uds

A uds library for python
MIT License
95 stars 54 forks source link

"self" used in static methods can be confusing #9

Closed beckyc567 closed 5 years ago

beckyc567 commented 5 years ago

In UdsConfigTool.py, in "def readDataByIdentifier(self,diagnosticIdentifier)" ... use of "self" like this in a non-class function can be a little confusing ... but I appreciate this is in the "experiments" It's also light on comments describe what is happening here, but I know what it's doing. "target" may be a better parameter name than "self" in this context?

richClubb commented 5 years ago

self keyword changed to target to make this clearer