Fixed missing 1 required positional argument: 'ws'

richard-better / pushbullet.py

A python client for http://pushbullet.com

MIT License

575 stars 110 forks source link

Fixed missing 1 required positional argument: 'ws' #138

Closed wecsam closed 5 years ago

wecsam commented 5 years ago

As of version 0.53.0 of websocket-client (websocket-client/websocket-client@efcf31b), the ws parameter is no longer needed.

coveralls commented 5 years ago

Coverage remained the same at 57.381% when pulling 01c791c13748aca9f55c1c3d51ed635f0a0f3fd4 on wecsam:master into d19ccb4646ed7a6af2e8a5fe583dbede18b57908 on randomchars:master.

GustavoKatel commented 5 years ago

Any updates on this? This would be very much appreciated.

wecsam commented 5 years ago

I haven't heard anything. I don't know whether anything else needs to be done before this is merged. You could just use my fork in the meantime, I suppose.

GustavoKatel commented 5 years ago

I'm not sure either 😕 The last commit on the master branch was in January. Is it still under development?

GustavoKatel commented 5 years ago

Maybe @randomchars or @kovacsbalu can give us a hint?