richard-better / pushbullet.py

A python client for http://pushbullet.com
MIT License
575 stars 110 forks source link

Fix: Do not use the non-public parse_requirements #46

Closed foosel closed 9 years ago

foosel commented 9 years ago

pip.req.parse_requirements is not considered part of the public pip API by the pip developers and hence should never be used as such. Its signature can change at any given moment, making installations depending on it just break.

This patch moves the actual requirement specification over into setup.py and modifies requirements.txt to only contain a reference to the local package, in compliance with the suggested usage pattern for setup.py vs requirements.txt.

See also:

Solves #36

Booli commented 9 years ago

+1

Salandora commented 9 years ago

+1

pauly7300 commented 9 years ago

+1

imrahil commented 9 years ago

+1