search

richard-better / pushbullet.py

A python client for http://pushbullet.com
MIT License
575 stars 110 forks source link

Add title parameter for send_file in device and channel objects. Improves #52 #90

Closed michaelarnauts closed 8 years ago

michaelarnauts commented 8 years ago

52 added the title parameter to pushbullet.py, but the channel and device objects didn't have this parameter in send_file.

kovacsbalu commented 8 years ago

Hi @michaelarnauts, can you please add/fix tests for your change?

michaelarnauts commented 8 years ago

I'm not sure if it's okay that I changed the body to body=body, but since the declaration of push_file is also a dict, I think this is the best way?

Also, I'm not really into python development, so I hope this change makes sense :)

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 55.527% when pulling 30e47fe74f6bb3a6a85473d5e6a0baa9ac75735b on michaelarnauts:title_in_channel_and_device into fa9f764c8f6584ebaa0a67ab26ab0c05e6f7de65 on randomchars:master.

michaelarnauts commented 8 years ago

I still get an error AttributeError: 'str' object has no attribute 'decode', but that seems to be unrelated to my change and is already present in master.

kovacsbalu commented 8 years ago

I will fix AttributeError soon.

michaelarnauts commented 8 years ago

Should be all green now.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 56.489% when pulling b4d9ca5b3d3843286b55ac3375cfb82f4b0d2b08 on michaelarnauts:title_in_channel_and_device into c6c9a80eca59a5caebaf2c4c74f7a69252fbc817 on randomchars:master.

kovacsbalu commented 8 years ago

Yes, I fixed the attribute error. What about your tests?

kovacsbalu commented 8 years ago

You not need to write body=body but when you write only title=tile is important. So when you skip an optional arg.

kovacsbalu commented 8 years ago

Looks good! Thank you! :)