search

richard-uk1 / alpm

ffi for alpm in rust
Apache License 2.0
11 stars 5 forks source link

make new release? #16

Open vn971 opened 5 years ago

vn971 commented 5 years ago

Sorry for raising it like this... But are you aware of the existence of forks? If you could merge the functionality and make a new release, it'd be great! The version in this pull request builds on stable Rust.

// I've temporarily forked the lib on crates.io using the name "libalpm-fork" (https://github.com/vn971/alpm) , but I'd happily delete it if upstream release will be made.

vn971 commented 5 years ago

I've reviewed the changes myself as well, making some small corrections along the way: da124c7 Two things that I do not understand yet: libalpm/src/event.rs -- why was Unknown deleted? libalpm/src/package.rs -- why was ` => panic!` deleted?

vn971 commented 5 years ago

OK, so the native tests pass now. Need to make docker work now.

vn971 commented 5 years ago

TBH I'm slowly starting to give up on docker for "alpm-sys".. It doesn't even have any tests. It only tests compilation, which is checked with a local cargo publish anyway. (Note though that all non-docker tests work fine now.)

The appropriate way, it seems, would be to e.g. create a Dockerfile. But haven't touched docker for quite a while.

vn971 commented 5 years ago

Thoughts?

richard-uk1 commented 5 years ago

Hi - sorry this is quite a big patch. I need to go through it all.

vn971 commented 5 years ago

@derekdreery yes, I understand. Took a considerable effort for me to do it as well.

vn971 commented 5 years ago

@derekdreery any news? If we can drop off testing in Docker for now, it'll be sad of course, but then again we wouldn't have to maintain the fork for now. Testing in docker could be added back later I guess, if libalpm starts compiling on stable Rust and somebody would be interested...

Not sure of course. Thoughts?

richard-uk1 commented 5 years ago

This is a very large patch, and I don't really have time to review. I recommend forking this project, and making a new crate on crates.io.

I will try to review if I get some time in the future, but I don't know when that might be.

vn971 commented 5 years ago

@derekdreery would you prefer to fork the project on cargo/crates as well?

I've done it here in Nov 2018 https://crates.io/crates/libalpm-fork because I've needed a newer version. Should it remain a fork on crates.io or you'd prefer to merge instead?

vn971 commented 5 years ago

By the way, I didn't tell it explicitly, but I'm using the project in an AUR helper that I'm building: https://github.com/vn971/rua So kudos for the project, it really does help :+1: !