search

richard-uk1 / alpm

ffi for alpm in rust
Apache License 2.0
11 stars 5 forks source link

Look at why Transaction moves value, rather than taking reference. #7

Open richard-uk1 opened 7 years ago

richard-uk1 commented 7 years ago

I don't see the benefit of consuming and then recover an Alpm instance. I would make the Transaction struct keep a reference to an alpm_handle_t instead.

richard-uk1 commented 7 years ago

I understand what you say. There must be a reason why I did this, but I cannot remember it. I'll have a look and try to work it out.

richard-uk1 commented 7 years ago

I've rewrote transaction now to use references.