search

richard1122 / vscode-youcompleteme

YouCompleteMe for VSCode
https://marketplace.visualstudio.com/items?itemName=RichardHe.you-complete-me
MIT License
53 stars 8 forks source link

show diagnostic for errors in header file #43

Closed joelhock closed 7 years ago

joelhock commented 7 years ago

If there are issues we come across in files other than the one we're looking at, it's probably from an included header. Since they may be the root cause of errors in the file we're looking at, instead of filtering them all out, let's just pick the first one to display and hard-code it to show up on the first line, since the language server diagnostic interface doesn't appear to be able to report errors in different files.

richard1122 commented 7 years ago

Hi, Thanks for your PR.

This is an really useful change.

I've changed some code and will merge it soon.

Thanks!

joelhock commented 7 years ago

Thanks for the lint fix--i'll remember to do that beforehand in the future. I've been programming in c++ / Python for too long--Typescript is new to me!

I have a couple more fixes in the works and should have the pull requests coming out over the next few days.

joel

On Thu, Jun 15, 2017 at 5:10 AM, Richard notifications@github.com wrote:

Hi, Thanks for your PR.

This is an really useful change.

I've changed some code and will merge it soon.

Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/richard1122/vscode-youcompleteme/pull/43#issuecomment-308674840, or mute the thread https://github.com/notifications/unsubscribe-auth/AHS2vTrXv-qk1jQDfch-moKyNW92N1Epks5sEPTogaJpZM4N6F4a .